Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRO-1852 refactor, update to uber gomock, remove unused code, update how we create a user device #194

Merged
merged 11 commits into from
Sep 1, 2023
Merged

PRO-1852 refactor, update to uber gomock, remove unused code, update how we create a user device #194

merged 11 commits into from
Sep 1, 2023

Conversation

JamesReate
Copy link
Member

Proposed Changes

A lot of stuff in this Pr but namely:

  • use shared cloudevent instead of local duplicate one
  • update to use uber gomock
  • refactor out CreateUserDevice logic and update code paths to use it
  • update various unit tests per new code path for creating a user device
  • remove a lot of unused code
  • refactor how we set powertrain type
  • log if when in USA we change the powertrain due to discrepancy with NHTSA

Impacted Routes

Caveats

@JamesReate JamesReate merged commit f01eb04 into main Sep 1, 2023
2 checks passed
@JamesReate JamesReate deleted the pro-1852-refactor branch September 1, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JamesReate